fix(serialport): add mutex for thread-safe access of isClosing bool status
#1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1009 +/- ##
==========================================
- Coverage 20.14% 20.09% -0.05%
==========================================
Files 42 42
Lines 3221 3229 +8
==========================================
Hits 649 649
- Misses 2487 2495 +8
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dido18
changed the title
isClosing bool status
cmaglie
requested changes
Jan 17, 2025
Comment on lines
+90
to
+98
| p.mu.Lock() | ||
| //if we detect that port is closing, break out of this for{} loop. | ||
| if p.isClosing { | ||
| strmsg := "Shutting down reader on " + p.portConf.Name | ||
| log.Println(strmsg) | ||
| h.broadcastSys <- []byte(strmsg) | ||
| break | ||
| } | ||
| p.mu.Unlock() |
There was a problem hiding this comment.
If the break path is taken doesn't the mutex remain locked?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
Fix a DATA RACE on the
isClosingvariable of the seiral port.There are two routines that read and write the
isClosingvariable concurrently.opencommand reads theisClosingvariable to verify if it must stop reading from the serial portclosecommand writes theisClosing(setting to true) variable to inform that the serial port must be closed.Add a mutex to control the access of the shared variable (another approach could have been adding a channel to inform to close the serial port)